Skip to content

WIP: fix fuse tests hanging - #6196

Closed
ThomasWaldmann wants to merge 14 commits into
borgbackup:masterfrom
ThomasWaldmann:macos-ci-fixes-master
Closed

WIP: fix fuse tests hanging#6196
ThomasWaldmann wants to merge 14 commits into
borgbackup:masterfrom
ThomasWaldmann:macos-ci-fixes-master

Conversation

@ThomasWaldmann

Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/workflows/ci.yml
Comment on lines +98 to +99
sudo tccutil --service kTCCServiceSystemPolicyAllFiles --insert /bin/sh
sudo tccutil --enable /bin/sh

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work, likely SIP is enabled.

@ThomasWaldmann

Copy link
Copy Markdown
Member Author

@m3nu any idea how to get test_fuse not hanging forever?

@m3nu

m3nu commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Installing and running FUSE in an automated way is ambitious. Doesn't it need confirmation of the module in the Security Preferences? If so, there is probably a notification popup blocking somewhere.

I can check for that by taking screenshots while Github Actions is running, but may not have a solution for the actual error. Similar to doing things with the Keychain. One needs to be very very careful to avoid triggering a confirmation message.

@m3nu

m3nu commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Will try this today. We shouldn't disable SIP or any other feature.

@m3nu m3nu self-assigned this Feb 20, 2022
@m3nu

m3nu commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Here where it gets stuck.

The workarounds in the script are being blocked. Looking at other options to install this headless. (added debug code here m3nu@3a290ea)

test

@m3nu

m3nu commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Looked into this a bit more (macfuse/macfuse#828 (comment)) and don't think we should spend time to override a security feature here. Better to mock the MacFUSE parts and focus on the code Borg runs.

@m3nu

m3nu commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Only alternative I see is Vagrant or something local, which allows disabling SIP.

@ThomasWaldmann

Copy link
Copy Markdown
Member Author

@m3nu thanks for investigating! ok, so according to your results / advice, we'll have:

  • github CI running on old macOS that doesn't need problematic tweaks (as long as that OS is offered / works otherwise for us)
  • local vagrant based testing (currently also on old macOS, in future maybe some newer OS with a locally prepared VM)

So I am closing this PR, won't work like this.

@ThomasWaldmann

Copy link
Copy Markdown
Member Author

well, github is deprecating macOS 10 based testing. today a test failed with a note telling so.

so guess we have the same problem again on github as we are now forced to move to macOS 11 or 12.

@ThomasWaldmann
ThomasWaldmann deleted the macos-ci-fixes-master branch September 13, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants